Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy2 #1985

Merged
merged 6 commits into from
May 12, 2024
Merged

numpy2 #1985

merged 6 commits into from
May 12, 2024

Conversation

andrewgsavage
Copy link
Collaborator

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1985 will not alter performance

Comparing andrewgsavage:numpy2 (456be93) with master (cbdd79e)

Summary

✅ 437 untouched benchmarks

@andrewgsavage andrewgsavage mentioned this pull request May 12, 2024
Merged
5 tasks
@andrewgsavage andrewgsavage merged commit cb0ec94 into hgrecco:master May 12, 2024
41 of 42 checks passed
@andrewgsavage andrewgsavage deleted the numpy2 branch May 12, 2024 18:32
keewis
keewis reviewed May 12, 2024
View reviewed changes
pint/testsuite/test_numpy.py
def test_ptp(self):
assert self.q.ptp() == 3 * self.ureg.m
if not np.lib.NumpyVersion(np.__version__) >= "2.0.0b1":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably use @pytest.mark.skipif(np.lib.NumpyVersion(np.__version__) >= "2.0.0b1, reason="removed in numpy2") instead here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

takluyver pushed a commit to takluyver/pint that referenced this pull request Jun 18, 2024
@andrewgsavage @takluyver
numpy2 support (hgrecco#1985)
31a9748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgrecco hgrecco hgrecco left review comments

@keewis keewis keewis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewgsavage @hgrecco @keewis