Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async def function formatting #728

Merged
merged 1 commit into from
Mar 14, 2024
Merged

async def function formatting #728

merged 1 commit into from
Mar 14, 2024

Conversation

j-z10
Copy link
Contributor

@j-z10 j-z10 commented Mar 12, 2024

as described in issue #727

source code

async def async_function_foo(argument_01: int, argument_02: int, argument_03: int, argument_04: int, argument_05: int, argument_06: int) -> int:
    return argument_01 + argument_02 + argument_03 + argument_04 + argument_05 + argument_06

def sync_function_foo(argument_01: int, argument_02: int, argument_03: int, argument_04: int, argument_05: int, argument_06: int) -> int:
    return argument_01 + argument_02 + argument_03 + argument_04 + argument_05 + argument_06

cmd line

autopep8 -aaa --experimental --max-line-length 120

before

async def async_function_foo(argument_01: int, argument_02: int, argument_03: int, argument_04: int, argument_05: int, argument_06: int) -> int:
    return argument_01 + argument_02 + argument_03 + argument_04 + argument_05 + argument_06


def sync_function_foo(
        argument_01: int,
        argument_02: int,
        argument_03: int,
        argument_04: int,
        argument_05: int,
        argument_06: int) -> int:
    return argument_01 + argument_02 + argument_03 + argument_04 + argument_05 + argument_06

when this pr finished

async def async_function_foo(
        argument_01: int,
        argument_02: int,
        argument_03: int,
        argument_04: int,
        argument_05: int,
        argument_06: int) -> int:
    return argument_01 + argument_02 + argument_03 + argument_04 + argument_05 + argument_06


def sync_function_foo(
        argument_01: int,
        argument_02: int,
        argument_03: int,
        argument_04: int,
        argument_05: int,
        argument_06: int) -> int:
    return argument_01 + argument_02 + argument_03 + argument_04 + argument_05 + argument_06

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (af7399d) to head (204dc6a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files           1        1           
  Lines        2402     2402           
=======================================
  Hits         2350     2350           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hhatto hhatto self-requested a review March 14, 2024 00:16
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!
LGTM 👍

@hhatto hhatto merged commit 30e79c9 into hhatto:main Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants