Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unnecessary updateSettingValue call #12

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

522122
Copy link

@522122 522122 commented Aug 12, 2024

Since navigating left / right in slider is already calling server, there is no need to do it on confirmation. Was only causing issue where selChoice populated when entered the field was replacing already update value #11.

@antheas
Copy link
Contributor

antheas commented Aug 13, 2024

While i will check this tomorrow, make sure your change does not interfere with another "multiple" field.

Multiple fields are dropdown ones. I think the "ordinal" tag styles them as a bar.

There is a difference in behavior between them. Dropdown fields are applied using the bit of code you removed and only when you hit A.

Perhaps this code is not needed when the tag ordinal exists. In this case, check for that tag and skip the apply tag if it exists.

@522122
Copy link
Author

522122 commented Aug 13, 2024

You are right. This is working only for multiple with ordinal tag. Multiple without tags like tdp.amd_energy.mode.manual.sched are not working.

@antheas antheas merged commit bc34c1e into hhd-dev:main Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants