Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully delegate installation rstantools #24

Merged
merged 4 commits into from
Apr 1, 2023

Conversation

andrjohns
Copy link
Contributor

This PR updates your package to fully delegate the installation/compilation of stan models to rstantools.

Note that your package appears to be missing a utility_FA.cpp file and does not build

@bgoodri
Copy link

bgoodri commented Mar 10, 2023

We need this PR to be merged and released to CRAN in order to release the StanHeaders that has been years in the making but is still years behind the current Stan development branch. Please do so this week.

@andrjohns
Copy link
Contributor Author

FYI that your latest CRAN release removed rstantools from your DESCRIPTION file's Imports, which means that your package will fail to compile unless the user already has rstantools installed - it won't be installed as part of your package's dependencies. We strongly recommend that you re-add rstantools to your Imports

@andrjohns
Copy link
Contributor Author

Additionally, your package is still failing to build against the next StanHeaders because there are compilation flags missing from your Makevars. We recommend using the rstantools-based approach from this PR so that your package always remains compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants