Skip to content

Commit

Permalink
Revert "Maintenance / investigation: reapply lxml workaround for MacO…
Browse files Browse the repository at this point in the history
…S unit test workflows (#779)"

This reverts commit 0a875e8.

Conflicts:
	.github/workflows/unittests.yaml
  • Loading branch information
jayaddison committed Oct 20, 2024
1 parent 7413347 commit 2deba9c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/unittests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
include:
# set toxenv to workaround-darwin on macos (check tox.ini)
- toxenv: py
- os: macos-latest
toxenv: workaround-darwin
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand All @@ -32,4 +27,4 @@ jobs:
- name: Run Tests
run: |
pip install tox
tox -e ${{ matrix.toxenv }}
tox
9 changes: 0 additions & 9 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,6 @@ isolated_build = true
deps = -r{toxinidir}/requirements-dev.txt
commands = coverage run -m unittest {posargs}

# The system-provided libxml2 on MacOS is typically outdated and this can lead to lxml parsing issues
# Using PyPi-provided binary wheels instead resolves this
# We are affected by https://bugs.launchpad.net/lxml/+bug/1949271 in test_wild_mode when using system-provided libxml2 on MacOS
platform =
workaround-darwin: darwin
install_command =
py: python -I -m pip install {opts} {packages}
workaround-darwin: python -I -m pip install --only-binary=lxml {opts} {packages}

[testenv:lint]
# note: skip_install affects whether the package-under-test is installed; not whether deps are installed
skip_install = true
Expand Down

0 comments on commit 2deba9c

Please sign in to comment.