Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup: don't emit a deprecation notice for 'options' due to a single keyword-argument of 'wild_mode'. #1191

Merged

Conversation

jayaddison
Copy link
Collaborator

Resolves #1190.

@jayaddison jayaddison force-pushed the issue-1190/options-deprecation-not-relevant-for-wild-mode branch from f4ace43 to 3e56759 Compare July 26, 2024 11:22
@jayaddison jayaddison force-pushed the issue-1190/options-deprecation-not-relevant-for-wild-mode branch from 5d8b41c to 2dae9e5 Compare July 26, 2024 11:28
@jayaddison jayaddison marked this pull request as ready for review July 26, 2024 11:30
@jayaddison jayaddison merged commit 24d7aaa into main Jul 26, 2024
19 checks passed
@jayaddison jayaddison deleted the issue-1190/options-deprecation-not-relevant-for-wild-mode branch July 26, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: deprecation notice for 'options' incorrectly emits message when 'wild_mode' argument is provided.
1 participant