Adds 7 new site coverages #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what is causing the issue & im unable to replicate it locally. Some of the unittests are passing & others failing on the readme |
jayaddison
reviewed
Aug 13, 2024
jayaddison
reviewed
Aug 14, 2024
jayaddison
reviewed
Aug 14, 2024
jayaddison
reviewed
Aug 14, 2024
jayaddison
reviewed
Aug 14, 2024
jayaddison
reviewed
Aug 14, 2024
jayaddison
reviewed
Aug 14, 2024
|
A few nitpicks, but generally these look good to me, thanks @jknndy - I'll add another round of review after you have time to respond. |
Co-authored-by: James Addison <55152140+jayaddison@users.noreply.github.com>
jayaddison
reviewed
Aug 14, 2024
|
All caught up! |
jayaddison
reviewed
Aug 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: James Addison <55152140+jayaddison@users.noreply.github.com>
jayaddison
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All schema based with
ingredient_groupingcoverage & 1 with equipmentResolves #1145