Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Mob scraper #1198

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Updates to Mob scraper #1198

merged 1 commit into from
Jul 31, 2024

Conversation

jknndy
Copy link
Collaborator

@jknndy jknndy commented Jul 30, 2024

  • Pulled new test data for both cases
  • No longer returns a static value for site_name
  • Updated the ratings method to return a float with two decimal places instead of a string
  • Removed coverages no longer available (keywords & nutrients)

@jknndy jknndy marked this pull request as ready for review July 30, 2024 22:43
jayaddison
jayaddison approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@jayaddison jayaddison merged commit cc45b63 into hhursev:main Jul 31, 2024
19 checks passed
@jknndy jknndy deleted the mob-updates branch July 31, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayaddison jayaddison jayaddison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jknndy @jayaddison