Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add package description metadata retrieval for Python 3.9 and earlier #1218

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

jayaddison
Copy link
Collaborator

Enables the unit test added in #1162 to run on all of the versions of Python supported by the library.

@jayaddison jayaddison requested a review from jknndy August 15, 2024 10:25
Copy link
Collaborator

@jknndy jknndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the appropriate timeline for dropping support of outdated python versions? Is it project-preference or is there a standard recommendation?

@jayaddison
Copy link
Collaborator Author

What's the appropriate timeline for dropping support of outdated python versions? Is it project-preference or is there a standard recommendation?

It is project preference, yep. That said, some standard practices, such as Scientific Python's SPEC-0, do exist.

Because this library doesn't have many or complex dependencies, I think it generally makes sense to support a fairly wide version range.

Dropping Python versions when they're no longer supported by upstream Python (see the Python devguide version reference) can make sense to encourage people to upgrade, and to allow us to gradually opt-in to more recent language features (pyupgrade is one way to check for some commonly-recommended ideas).

@jayaddison
Copy link
Collaborator Author

Thank you for the code review @jknndy!

@jayaddison jayaddison merged commit 461e9b7 into main Aug 15, 2024
19 checks passed
@jayaddison jayaddison deleted the pr-1162-followup/backport-importlib branch August 15, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants