-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usapears: implement redundant-nutrient-value filtering #1294
Merged
jayaddison
merged 8 commits into
main
from
issue-1289/usapears-nutrient-name-redundancy
Oct 17, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a06e166
Tests: update nutrient test data expectations for `usapears`
jayaddison fe814d7
usapears: override default `nutrients` field implementation (without …
jayaddison 91c3b3b
usapears: implement redundant-nutrient-value filtering
jayaddison 7f4aca4
Tests: usapears: remove fiber expectation (no longer provided by webp…
jayaddison cbd553c
Tests: usapears: remove ratings expectations
jayaddison b46483b
Tests: update test data for `usapears`
jayaddison e2353a5
usapears: corrections for two nutrient field names
jayaddison 36dcc89
usapears: add additional correction for fat/fatContent
jayaddison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll merge this as-is, but a note about something I realized while self-reviewing my changes: we're a bit inconsistent throughout the codebase about usage of the arguments to the
ElementNotFoundInHtml
initializer, and what their purpose is. There might be an opportunity to improve the consistency/functionality there in future.