Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: suppress static-value warnings during GitHub Actions unit test workflow #1335

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jayaddison
Copy link
Collaborator

This should produce less-noisy output in the build logs of our GitHub Actions unit test workflows.

To do so, it enables propagation of the PYTHONWARNINGS environment variable to the relevant tox environment/task - so anyone using tox for local development can also configure the same behaviour.

@jayaddison
Copy link
Collaborator Author

One particular motivating factor for this change is that I'd like to reduce the overall resource usage of our GitHub Actions workflows, partly because although individual per-website pull requests are much easier to review, they do create a fan-out effect that results in an increased number continuous integration workflow jobs.

GitHub provides free resources for public open source projects such as this one, but even so: we should not expend resources inefficiently. Adjustments here should reduce the amount of disk space resource usage (with perhaps some minimal reduction in CPU -- and perhaps some effect on network, depending on whether those logs are retrieved/shipped elsewhere for storage and display purposes).

@jayaddison
Copy link
Collaborator Author

perhaps some minimal reduction in CPU

I suppose this assumes that the CPU cost to detect/filter the relevant log messages is lower than the CPU cost to handle and print them to output -- that is potentially ambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant