Adds support for Eatwell101.com #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
reviewed
Sep 21, 2023
jayaddison
reviewed
Sep 21, 2023
|
|
||
| def test_instructions(self): | ||
| expected_instructions = ( | ||
| "1. To make the creamy spinach turkey meatballs: In a large bowl, combine ground turkey and ground chicken, cheese, grated garlic, Italian seasoning, bouillon cube, red chili pepper flakes, chopped cilantro, and black pepper. Mix well with your hands or fork and form medium balls. Arrange the turkey meatballs on a plate and set them aside.\n" |
There was a problem hiding this comment.
I think I generally still prefer the "\n".join([instruction, instruction, ...]) pattern, but after seeing it more often I'm beginning to come around to this representation despite the \n at the end of each line in the code.
(no change requested here, just explaining some of my thoughts as I review)
There was a problem hiding this comment.
I think this way makes it easier to read & lets the joining be handled directly in the scraper class. If you prefer the other way I can definitely try to swap it
|
Looks good to me - thank you, @jknndy! After the HTML-unescaping change, I think this is ready for merge. |
Added html.unescape to category and fixed deprecation warning for ingredients.
jayaddison
reviewed
Sep 23, 2023
| @@ -31,7 +32,7 @@ def image(self): | |||
|
|
|||
| def ingredients(self): | |||
| ingredients_h2 = self.soup.find( | |||
| "h2", text=re.compile(r"Ingredients", re.IGNORECASE) | |||
| "h2", string=re.compile(r"Ingredients", re.IGNORECASE) | |||
jayaddison
approved these changes
Sep 23, 2023
strangetom
pushed a commit
to strangetom/recipe-scrapers
that referenced
this pull request
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #787