-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonical url intergration batch #2 #902
Merged
jayaddison
merged 16 commits into
hhursev:main
from
jknndy:canonical_url_intergration_batch_2
Oct 11, 2023
Merged
Canonical url intergration batch #2 #902
jayaddison
merged 16 commits into
hhursev:main
from
jknndy:canonical_url_intergration_batch_2
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/jknndy/recipe-scrapers into canonical_url_intergration_batch_2
Drops support for yields field. not available in schema or a definitive location on page.
Site no longer exists, became part of food.com which exists in sperate scraper class.
Site no longer contains recipes.
jayaddison
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - glad to hear that this batch was simpler to update 👍
strangetom
pushed a commit
to strangetom/recipe-scrapers
that referenced
this pull request
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This batch was incredible easy compared to the first!
Dropped support
GeniusKitchen - Site no longer exists, moved to food.com
heinzbrasil - Site doesn't contain any recipes anymore.
Scraper Changes
GreatBritishChef - Dropped yields field
Heb - Total rework