Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support offset #1172

Merged
merged 5 commits into from
Sep 16, 2021
Merged

support offset #1172

merged 5 commits into from
Sep 16, 2021

Conversation

mxlxm
Copy link
Contributor

@mxlxm mxlxm commented Aug 29, 2021

fix #847,#739,#647.

@LeoQuote
Copy link
Collaborator

感谢 pr, 请先rebase 一下到最新分支.

@LeoQuote
Copy link
Collaborator

测试没过, 不兼容原有的 limit 关键词改写

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1172 (bf88b63) into master (f24d059) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head bf88b63 differs from pull request most recent head 9e66c17. Consider uploading reports for the commit 9e66c17 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage   77.89%   77.92%   +0.02%     
==========================================
  Files          76       76              
  Lines       11941    11948       +7     
==========================================
+ Hits         9302     9311       +9     
+ Misses       2639     2637       -2     
Impacted Files Coverage Δ
sql/engines/mysql.py 92.27% <100.00%> (+0.23%) ⬆️
sql/engines/tests.py 99.82% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae54ae6...9e66c17. Read the comment docs.

@hhyo hhyo merged commit f370593 into hhyo:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ bug ]mysql 查询 如果limit 带有offset,offset会失效
3 participants