-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
新增my2sql工具插件模块 #1224 #1314
新增my2sql工具插件模块 #1224 #1314
Conversation
新增my2sql工具插件模块
新增my2sql工具插件模块 - 新增权限
新增my2sql工具插件模块 - Dockerfile更新
新增my2sql工具插件模块 - 单元测试
Codecov Report
@@ Coverage Diff @@
## master #1314 +/- ##
==========================================
+ Coverage 77.89% 78.01% +0.12%
==========================================
Files 77 78 +1
Lines 12051 12220 +169
==========================================
+ Hits 9387 9534 +147
- Misses 2664 2686 +22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看了下, 是用plugin实现的, 功能都完备, 本地测试没问题的话就ok
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker 编译没过, 其他ok, 修下 docker build
修改了dockerfile-base,但是workflow里依赖的archery-base镜像好像不能自动构建? Line 1 in f588e8b
|
新增my2sql工具插件模块 - 漏洞修复&Dockerfile调整
暂时保留dockerfile-base里的my2sql依赖
dockerfile已调整 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
修复shell命令注入漏洞 - 通过实例信息注入
通过path和实例信息注入的漏洞已修复 #1316 |
修复shell命令注入漏洞 - 通过实例信息注入
新增my2sql工具插件模块 #1224
对比了主流的几款闪回工具,MyFlash很快接近原生mysqlbinlog,缺点是不能生成直观可读的sql,而且非常吃内存,不支持mysql 8;binlog2sql功能性强,但是太慢了,在生产环境的大数据量下显得无力,而且同样对于mysql 8存在兼容性问题;my2sql算是比较均衡的,筛选功能丰富,实测解析速度能达到binlog2sql的5倍以上