Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改审计表额外信息字段长度 #1356

Merged
merged 4 commits into from
Jan 25, 2022
Merged

修改审计表额外信息字段长度 #1356

merged 4 commits into from
Jan 25, 2022

Conversation

weideguo
Copy link
Collaborator

关联pr #1349 pr #1342

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1356 (b68d013) into master (fb84fd1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1356   +/-   ##
=======================================
  Coverage   75.39%   75.39%           
=======================================
  Files          81       81           
  Lines       12616    12616           
=======================================
  Hits         9512     9512           
  Misses       3104     3104           
Impacted Files Coverage Δ
sql/models.py 95.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb84fd1...b68d013. Read the comment docs.

@LeoQuote
Copy link
Collaborator

为啥要改长度?以前的数据类型有什么问题?

@weideguo
Copy link
Collaborator Author

@hhyo 说考虑到SQL查询可能会很长,感觉很有道理。 @LeoQuote

LeoQuote
LeoQuote previously approved these changes Jan 24, 2022
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weideguo
Copy link
Collaborator Author

weideguo commented Jan 24, 2022

bootstrap-table的版本有问题,需要降到更低版本,之前我以为获取value为string是特性,但降低到1.8.3发现并没重现,应该是bug,但发现还有其他问题,我先测测看降到哪个版本。@hhyo

@hhyo
Copy link
Owner

hhyo commented Jan 24, 2022

bootstrap-table的版本有问题,需要降到更低版本,之前我以为获取value为string是特性,但降低到1.8.3发现并没重现,应该是bug,但发现还有其他问题,我先测测看降到哪个版本。@hhyo

确认下账号管理里面的权限样式错误也是升级导致的么

@weideguo
Copy link
Collaborator Author

bootstrap-table的版本有问题,需要降到更低版本,之前我以为获取value为string是特性,但降低到1.8.3发现并没重现,应该是bug,但发现还有其他问题,我先测测看降到哪个版本。@hhyo

确认下账号管理里面的权限样式错误也是升级导致的么

就是这个错误,降到1.18.3时可以解决这个问题。但表格的字段的长度还是出现问题,设置为60%,但渲染却为60px,降到1.15.2也还是出现这样问题。

@weideguo
Copy link
Collaborator Author

应该修复好了 @hhyo @LeoQuote

@hhyo hhyo merged commit 3418432 into hhyo:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants