-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #2252 #2266
fix #2252 #2266
Conversation
…tabaseError-DPI-1059-1 fix hhyo#2252
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
- Coverage 75.51% 75.50% -0.02%
==========================================
Files 107 107
Lines 15460 15460
==========================================
- Hits 11675 11673 -2
- Misses 3785 3787 +2
☔ View full report in Codecov by Sentry. |
lint 修一下谢谢,只需要 black . —exclude venv 就可以了 另外不需要这样反复close open,只需要往你的分支里推送新代码,pr会自动更新的 |
@LeoQuote sry,昨天晚上加班,脑子有点迷糊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样改一下安全一些
@LeoQuote 非常感谢你的建议,基于你的建议我觉得get方法应该加上缺失默认值,避免key缺失导致异常。例如get("rows“, None) |
好的,不过get方法如果不指定第二个参数,返回的值就会是None |
fix #2252 使用conn.current_schema=db_name 替换ALTER SESSION SET CURRENT_SCHEMA = :db_name 。
fix #2262 由于sql检测中可能存在影响行数位none的情况,针对性修复