增加sql上线可执行时间选择，且审核人可修改这个时间 #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hhyo
reviewed
Jun 9, 2019
| @@ -180,6 +180,8 @@ class SqlWorkflow(models.Model): | |||
| engineer_display = models.CharField('发起人中文名', max_length=50, default='') | |||
| status = models.CharField(max_length=50, choices=SQL_WORKFLOW_CHOICES) | |||
| audit_auth_groups = models.CharField('审批权限组列表', max_length=255) | |||
| starttime = models.DateTimeField('可执行起始时间', null=True, blank=True) | |||
| @@ -69,6 +75,22 @@ def can_execute(user, workflow_id): | |||
| result = True | |||
| return result | |||
|
|
|||
| def on_Correct_time_period(workflow_id): | |||
There was a problem hiding this comment.
嗯 ， 我修改下 重新提， 昨天 看好久没动静 就撤掉了
|
建议不要关闭pr，直接在分支上推送，一旦关闭在代码基础上的讨论就都丢失了。看不到演化过程。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加sql上线可执行时间选择，且审核人可修改这个时间