Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于ViewGroupDataBinding的一个问题 #33

Closed
EdwinSmartBoy opened this issue May 9, 2022 · 6 comments
Closed

关于ViewGroupDataBinding的一个问题 #33

EdwinSmartBoy opened this issue May 9, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@EdwinSmartBoy
Copy link

image
我看FragmentDataBinding等都有调用destroyed，但是ViewGroupDataBinding的没有看到调用，感觉会导致内存泄漏的样子。
@hi-dhl
Copy link
Owner

hi-dhl commented May 11, 2022

@EdwinSmartBoy 收到，非常感谢反馈，这个问题之前没想好处理方案，这两天我处理一下

hi-dhl added a commit that referenced this issue May 11, 2022
@hi-dhl
fix: ViewGroup 销毁的时候释放资源 (#33)
0104c72
@EdwinSmartBoy
Copy link
Author

@EdwinSmartBoy 收到，非常感谢反馈，这个问题之前没想好处理方案，这两天我处理一下

非常感谢，我看到好像只是viewbind修改了，databind还没有修改。
大佬啥时候能提个版本呀，哈哈

@hi-dhl
Copy link
Owner

hi-dhl commented May 12, 2022

嗯嗯，这两天会提个新版本

@EdwinSmartBoy
Copy link
Author

嗯嗯，这两天会提个新版本

好的，非常感谢🥳🥳

hi-dhl added a commit that referenced this issue May 12, 2022
@hi-dhl
fix: ViewGroup 在 databinding 销毁的时候释放资源，添加声明周期检查 (#33)
f20a6d9
@hi-dhl
Copy link
Owner

hi-dhl commented May 12, 2022

@EdwinSmartBoy 已经更新了， maven 也通过了，可以正常使用了 1.1.5

@EdwinSmartBoy
Copy link
Author

@EdwinSmartBoy 已经更新了， maven 也通过了，可以正常使用了 1.1.5

感谢！

@hi-dhl hi-dhl closed this as completed May 17, 2022
@hi-dhl hi-dhl added the bug Something isn't working label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hi-dhl @EdwinSmartBoy