Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify server entry #408

Merged
merged 11 commits into from
Jun 1, 2023
Merged

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented May 28, 2023

Cherry picking simpler parts of #373.
This gives up server sourcemap (implemented in #263) but it's probably fine.

For some reason, remix's serverDependenciesToBundle = "all" reduces server size from 10MB to 6MB

Maybe I was doing something wrong with sourcemap?

@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Jun 1, 2023

Tested basic usage on production and it looks alright.

@hi-ogawa hi-ogawa enabled auto-merge (squash) June 1, 2023 12:22
@hi-ogawa hi-ogawa disabled auto-merge June 1, 2023 12:23
@hi-ogawa hi-ogawa changed the title chore: simplify vercel build chore: simplify server entry Jun 1, 2023
@hi-ogawa hi-ogawa changed the title chore: simplify server entry refactor: simplify server entry Jun 1, 2023
@hi-ogawa hi-ogawa merged commit 7a25fe6 into master Jun 1, 2023
@hi-ogawa hi-ogawa deleted the refactor-simplify-vercel-build branch June 1, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant