Add rewrite support for gradle.GradleBestPractices
#10731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
Pankraz76
commented
Aug 10, 2025
|
Is this any good? Kindly request some feedback. To pitch this, as there is no issue or discussion section for me enabled to post, im providing the issue the PoC in one thread. Please excuse this. Thanks for considering. |
Pankraz76
changed the title
errorprone.refasterrulesrewrite support for tech.picnic.errorprone.refasterrules.FileRulesRecipes
|
BUILD SUCCESSFUL |
gavinking
reviewed
Aug 10, 2025
...c/test/java/org/hibernate/orm/test/annotations/onetoone/OneToOneJoinTableUniquenessTest.java
Outdated
Show resolved
Hide resolved
Pankraz76
changed the title
rewrite support for tech.picnic.errorprone.refasterrules.FileRulesRecipesrewrite support for org.openrewrite.gradle.GradleBestPractices
Pankraz76
changed the title
rewrite support for org.openrewrite.gradle.GradleBestPracticesrewrite support for gradle.GradleBestPractices
Pankraz76
commented
Aug 11, 2025
...-community-dialects/src/test/java/org/hibernate/community/dialect/AltibaseFunctionsTest.java
Show resolved
Hide resolved
Pankraz76
commented
Aug 11, 2025
|
We're not interested in this at this time. I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
rewritesupport forgradle.GradleBestPracticesI’d like to propose integrating Google’s Error Prone and its Picnic extension (demonstrated in Automating Away Bugs with Error Prone | PlatformCon 2023) to enable automated bug fixes via
rewriterules. This would complement Checkstyle’s static analysis capabilities by addressing semantic bugs rather than stylistic issues.Motivation
Error Prone’s
refaster/rewriterules can automatically:String.equals()misuse)Real-world adoptions show tangible benefits:
Rewritecovering S1144: Unused "private" methods should be removed checkstyle/checkstyle#17545rewritesupport forerrorprone.refasterrulespmd/pmd#5956Rewrite & PMDcovering S1144: Unused "private" methods should be removed opensearch-project/OpenSearch#18791rewritesupport forerrorprone.refasterrulesdiffplug/spotless#2576rewritesupport forerrorprone.refasterrulesapache/kafka#20219Proposal
errorprone.refasterrules-based rewritesDiscussion Points
Next Steps
I’m happy to:
relates to:
editorconfig.orgcheckstyle/checkstyle#16543Hi
Is this any good?
Might consider these changes suggested by
error.prone.Thanks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.