HHH-19812: Improvements on the Maven Enhance Plugin (Backport to 7.0)

[koentsje]

• HHH-19813: Fix the regression on the 'enableDirtyTracking' and 'enableLazyInitialization' default values and deprecate the setting
• HHH-19817: Add the JavaDoc Style documentation appropriate for Maven Plugins
• HHH-19820: Make sure that the enhancer is not doing anything if all the enablement parameters are false
• HHH-19816: Add Integration Tests for the Maven Enhance Plugin without using Maven Invoker

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

https://hibernate.atlassian.net/browse/HHH-19820
https://hibernate.atlassian.net/browse/HHH-19813
https://hibernate.atlassian.net/browse/HHH-19817

[mbellade]

Hey @koentsje, thanks for the backport - but the 7.0 branch of ORM is no longer maintained - I think you should rather target 7.1

[koentsje]

@mbellade, I didn't know that it's not maintained anymore. I was planning to provide also a backport for 7.1 but there has been a change in the Maven plugin starting from 7.0 that requires at least a mention in the migration guide. Let's ask @yrodiere what he thinks about this...

[yrodiere]

@mbellade, I didn't know that it's not maintained anymore. I was planning to provide also a backport for 7.1 but there has been a change in the Maven plugin starting from 7.0 that requires at least a mention in the migration guide. Let's ask @yrodiere what he thinks about this...

@koentsje you need to update the migration guide here, to mention what exactly changed in 7.0 itself.
Other changes seem unnecessary, since as @mbellade mentioned the branch is no longer maintained.

Though @mbellade I wonder if pushing a change to the migration guide will trigger a release? We kind of need to, if the migration guide gets published as a HTML file.

[mbellade]

Though @mbellade I wonder if pushing a change to the migration guide will trigger a release? We kind of need to, if the migration guide gets published as a HTML file.

It would (if there's a Jira issue in the commit message), scheduled releases are still enabled for the 7.0 branch

[koentsje]

It would (if there's a Jira issue in the commit message), scheduled releases are still enabled for the 7.0 branch

So I assume it also doesn't hurt adding the fix for the regression and the additional documentation?

[hibernate-github-bot]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[mbellade]

So I assume it also doesn't hurt adding the fix for the regression and the additional documentation?

Usually we avoid changing behavior for unmaintained branches, even though there might be bugs affecting them. Also, with this change we would be deprecating and change default parameter values for the plugin retroactively, I'm not sure if we want to do that.

[koentsje]

Usually we avoid changing behavior for unmaintained branches, even though there might be bugs affecting them. Also, with this change we would be deprecating and change default parameter values for the plugin retroactively, I'm not sure if we want to do that.

So maybe get rid of the change of default, the deprecation and the additional integration tests but still add the (slightly modified) documentation? Or is it all not worth it and I just add a short section to the migration guide?

Also I don't understand why there are failing jobs. Do I need to do something special for Quarkus or the TCK?

[yrodiere]

So maybe get rid of the change of default, the deprecation and the additional integration tests but still add the (slightly modified) documentation? Or is it all not worth it and I just add a short section to the migration guide?

I'd say the latter :)

Also I don't understand why there are failing jobs. Do I need to do something special for Quarkus or the TCK?

Unmaintained branch, nobody looking at CI, hence failing CI :) You can probably ignore it.

[mbellade]

So maybe get rid of the change of default, the deprecation and the additional integration tests but still add the (slightly modified) documentation? Or is it all not worth it and I just add a short section to the migration guide?

Sounds like the migration guide is a must, documentation wouldn't hurt if you want to leave it I guess.

Also I don't understand why there are failing jobs. Do I need to do something special for Quarkus or the TCK?

Those were already failing before, not related to your changes.