Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with reference fails if entity is associated to a column (non id) #1504

Closed
DavideD opened this issue Mar 13, 2023 · 2 comments · Fixed by #1696
Closed

Merge with reference fails if entity is associated to a column (non id) #1504

DavideD opened this issue Mar 13, 2023 · 2 comments · Fixed by #1696
Assignees
Labels
regression Something that was working before. A test that we have disabled
Milestone

Comments

DavideD added a commit that referenced this issue Mar 13, 2023
This is an unusual use case where the association is with an entity
column instead of the identifier. It's a specific case and the current
mapping, as it is, fails using regular Hibernate ORM anyway.

I've added a test with the persist that seems to work as expected.
@DavideD DavideD added the waiting We are waiting for another PR or issue to be solved before merging this one label Mar 14, 2023
@DavideD DavideD added regression Something that was working before. A test that we have disabled and removed Hibernate Reactive 2.0 labels Apr 5, 2023
@blafond blafond self-assigned this Jun 5, 2023
@DavideD DavideD removed the waiting We are waiting for another PR or issue to be solved before merging this one label Jun 7, 2023
@DavideD DavideD added this to the next milestone Jun 15, 2023
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jun 16, 2023
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jun 22, 2023
@blafond
Copy link
Member

blafond commented Jun 22, 2023

@DavideD I changed the EntityTypes.getIdentifier() method to mimic your changes in ORM's EntityType. I also tweaked our failing merge tests to mimic the new ORM merge test.

lates: https://github.com/blafond/hibernate-reactive/commits/1504-merge-reference

Now all Eager & Lazy merge tests fail because the initializer.getImplementation() forces a call to the reactive session's immediateLoad().

I'm assuming I need to route it to our reactiveImmediateLoad() to make this work, but right now it's only called in reactiveFetch()?

@DavideD
Copy link
Member Author

DavideD commented Jun 22, 2023

I'm assuming I need to route it to our reactiveImmediateLoad() to make this work, but right now it's only called in reactiveFetch()?

I haven't checked the code yet, but sounds right

blafond added a commit to blafond/hibernate-reactive that referenced this issue Jun 28, 2023
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jun 28, 2023
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jun 30, 2023
blafond added a commit to blafond/hibernate-reactive that referenced this issue Jun 30, 2023
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jul 5, 2023
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jul 5, 2023
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jul 5, 2023
* Sort import
* Format code
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jul 5, 2023
* Format code
* Remove warnings
DavideD added a commit that referenced this issue Jul 5, 2023
DavideD added a commit that referenced this issue Jul 5, 2023
* Sort import
* Format code
DavideD added a commit that referenced this issue Jul 5, 2023
* Format code
* Remove warnings
@DavideD DavideD modified the milestones: next, 2.0.3.Final Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something that was working before. A test that we have disabled
Projects
None yet
2 participants