Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable build with snapshots for the different branches and Hibernate ORM versions #1930

Closed
3 tasks done
DavideD opened this issue Jun 3, 2024 · 1 comment · Fixed by #1961
Closed
3 tasks done

Re-enable build with snapshots for the different branches and Hibernate ORM versions #1930

DavideD opened this issue Jun 3, 2024 · 1 comment · Fixed by #1961
Assignees
@DavideD
Labels
build Something related to the build
Milestone
2.4.0.CR1

Comments

@DavideD
Copy link
Member

DavideD commented Jun 3, 2024 •
edited
Loading

I think we need the following separate branches for the different ORM version:

  • Hibernate Reactive 2.3 with Hibernate ORM 6.5
  • Hibernate Reactive 2.4 with Hibernate ORM 6.6
  • Hibernate Reactive 3.0 with Hibernate ORM 7.0

A summary of the branches is available here: https://github.com/hibernate/hibernate-reactive/branches

I've decided to create separate branches where we can test the snapshots, and we will test non snapshots versions in main. This way, main won't fail as often and we can apply fixes when needed on the snapshots branches.
@DavideD DavideD added the build Something related to the build label Jun 3, 2024
@DavideD DavideD added this to the next milestone Jun 3, 2024
@DavideD DavideD self-assigned this Jun 4, 2024
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Update project version to 2.4.0-SNAPSHOT
e331190
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Update Hibernate ORM to 6.6.0.Alpha1
31b14ef
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Upgrade CI build
347c2cb
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 5, 2024
@DavideD
[hibernate#1930] Fix ORM version for building with snapshots
8b79b65
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Rename snapshot build
6f57e67
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Rename snapshot build
5885ef9 
It's more generic, so that we can refere to the same build on different
branches
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Fix ORM version for building with snapshots
400518e
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Update project version to 2.4.0-SNAPSHOT
5a6098e
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Update Hibernate ORM to 6.6.0.Alpha1
8a32e08
DavideD added a commit that referenced this issue Jun 5, 2024
@DavideD
[#1930] Upgrade CI build
74f6d58
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 11, 2024
@DavideD
[hibernate#1930] Update project version to 2.4.0-SNAPSHOT
eece956
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 11, 2024
@DavideD
[hibernate#1930] Update Hibernate ORM to 6.6.0.Alpha1
ef90872
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 11, 2024
@DavideD
[hibernate#1930] Upgrade CI build
d62282f
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 11, 2024
@DavideD
[hibernate#1930] Update project version to 2.4.0-SNAPSHOT
cf69c78
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 11, 2024
@DavideD
[hibernate#1930] Update Hibernate ORM to 6.6.0.Alpha1
6d8aaad
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 11, 2024
@DavideD
[hibernate#1930] Upgrade CI build
a7dc29e
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jul 11, 2024
@DavideD
[hibernate#1930] Update project version to 2.4.0-SNAPSHOT
ee4f002
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jul 11, 2024
@DavideD
[hibernate#1930] Update Hibernate ORM to 6.6.0.Alpha1
ae4bca3
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jul 11, 2024
@DavideD
[hibernate#1930] Upgrade CI build
3534e1b
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Aug 1, 2024
@DavideD
[hibernate#1930] Remove snapshots releases from main branch
c557508 
Snapshot builds tend to fail quite often and sometimes we cannot even
fix an issue until another project has been released.

I moved the build testing the snapshots under the branches `wip/*`.
This way the failure of a build using snapshots won't affect the
release of stable versions.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Aug 1, 2024
@DavideD
[hibernate#1930] Remove builds with snapshots from the main branch
05dc4b6 
Snapshots are released from branches `wip/*`
@DavideD DavideD linked a pull request Aug 1, 2024 that will close this issue
Remove snapshots releases from main branch #1961
Merged
@DavideD
Copy link
Member Author

DavideD commented Aug 1, 2024

I think we can considered this solved, snapshots are now built and released on OSSRH.
I'm a bit concerned about having separate branches and keeping the wip aligned with main. But we can experiment with it and adjust later as needed.

@DavideD DavideD closed this as completed Aug 1, 2024
DavideD added a commit that referenced this issue Aug 2, 2024
@DavideD
[#1930] Add snapshot repository for the examples
08599de 
We didn't include it in the past because we wanted to keep the examples
simpler. But, we need to be able to test the examples with the snapshots
and it's disabled on the `main` branch as default
DavideD added a commit that referenced this issue Aug 2, 2024
@DavideD
[#1930] Update GitHub action to build and release snapshots
bac90ce
DavideD added a commit that referenced this issue Aug 2, 2024
@DavideD
[#1930] Add snapshot repository for the examples
b12ade2 
We didn't include it in the past because we wanted to keep the examples
simpler. But, we need to be able to test the examples with the snapshots
and it's disabled on the `main` branch as default
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Aug 9, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
d5c9d47
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Aug 27, 2024
@DavideD @Hibernate-CI
[hibernate#1930] Change properties to test ORM 6.6 snapshots
a9966c9
DavideD added a commit that referenced this issue Aug 28, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
e0d79d6
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Sep 12, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
f23056e
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Sep 18, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
a287747
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Sep 18, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
79fbeef
DavideD added a commit that referenced this issue Sep 18, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
586b6c3
DavideD added a commit that referenced this issue Sep 18, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
b123b52
DavideD added a commit that referenced this issue Sep 25, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
527c092
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Sep 25, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 7.0 snapshots
6075045
DavideD added a commit that referenced this issue Sep 26, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
8d7394a
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Oct 4, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
1680822
DavideD added a commit that referenced this issue Oct 4, 2024
@DavideD
[#1930] Add snapshot repository for the examples
06679c6 
We didn't include it in the past because we wanted to keep the examples
simpler. But, we need to be able to test the examples with the snapshots
and it's disabled on the `main` branch as default
DavideD added a commit that referenced this issue Oct 4, 2024
@DavideD
[#1930] Update GitHub action to build and release snapshots
f333e89 
And print the actual Hibernate ORM version used
DavideD added a commit that referenced this issue Oct 4, 2024
@DavideD
[#1930] Update GitHub action to build and release snapshots
ef42cb5
DavideD added a commit that referenced this issue Oct 4, 2024
@DavideD
[#1930] Update GitHub action to build and release snapshots
4482fc4
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Oct 14, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
a7ee790
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Oct 14, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 7.0 snapshots
a531fb8
DavideD added a commit that referenced this issue Nov 12, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
a8ad1ac
DavideD added a commit that referenced this issue Nov 12, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
80741ff
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Nov 14, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 7.0 snapshots
58dc3b1
DavideD added a commit that referenced this issue Nov 18, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
533cb88
DavideD added a commit that referenced this issue Dec 2, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
d8ba9c1
DavideD added a commit that referenced this issue Dec 2, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
fdb886b
DavideD added a commit that referenced this issue Dec 2, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
b7a90e1
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 2, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
c9e78c7
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 3, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
c3b3e4f
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 13, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
aecf948
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 13, 2024
@DavideD
[hibernate#1930] Change properties to test ORM 6.6 snapshots
91256ce
DavideD added a commit that referenced this issue Dec 13, 2024
@DavideD
[#1930] Change properties to test ORM 6.6 snapshots
b88295f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
build Something related to the build
Projects
None yet
Milestone
2.4.0.CR1
Development

Successfully merging a pull request may close this issue.

Remove snapshots releases from main branch DavideD/hibernate-reactive
1 participant
@DavideD