Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use env-vars for passing secrets used during release #2027

Closed
sebersole opened this issue Dec 12, 2024 · 1 comment · Fixed by #2031
Closed

Use env-vars for passing secrets used during release #2027

sebersole opened this issue Dec 12, 2024 · 1 comment · Fixed by #2031
Assignees
@sebersole
Milestone
3.0.0.Beta2

Comments

@sebersole
Copy link
Member

Currently HR (and ORM) use Project properties for passing secrets used during release (OSSRH, signing, etc). This is a security concern; we should use env-vars instead.
@sebersole sebersole self-assigned this Dec 12, 2024
sebersole added a commit to sebersole/hibernate-reactive that referenced this issue Dec 12, 2024
@sebersole
[hibernate#2027] Use env-vars for passing secrets used during release
5df6c58
@sebersole sebersole mentioned this issue Dec 12, 2024
Merged
sebersole added a commit to sebersole/hibernate-reactive that referenced this issue Dec 12, 2024
@sebersole
[hibernate#2027] Use env-vars for passing secrets used during release
f865fa5
sebersole added a commit to sebersole/hibernate-reactive that referenced this issue Dec 12, 2024
@sebersole
[hibernate#2027] Use env-vars for passing secrets used during release
8a4c959
DavideD pushed a commit that referenced this issue Dec 20, 2024
@sebersole @DavideD
[#2027] Use env-vars for passing secrets used during release
763421e
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Dec 20, 2024
@sebersole @DavideD
[hibernate#2027] Use env-vars for passing secrets used during release
8e70e3a
DavideD pushed a commit that referenced this issue Dec 20, 2024
@sebersole @DavideD
[#2027] Use env-vars for passing secrets used during release
90815a6
DavideD pushed a commit that referenced this issue Dec 20, 2024
@sebersole @DavideD
[#2027] Use env-vars for passing secrets used during release
4be6b7b
@DavideD DavideD linked a pull request Dec 20, 2024 that will close this issue
Signing + env-vars #2031
Merged
@DavideD DavideD closed this as completed Dec 20, 2024
@DavideD DavideD added this to the 3.0.0.Beta2 milestone Dec 20, 2024
@DavideD
Copy link
Member

DavideD commented Dec 20, 2024

Merged in all the relevant branches: main, wip/*, and 2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebersole sebersole

Labels
None yet
Projects
None yet
Milestone
3.0.0.Beta2
Development

Successfully merging a pull request may close this issue.

Signing + env-vars sebersole/hibernate-reactive
2 participants
@sebersole @DavideD