Fix lazy one to one with bytecode enhancements #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
1417-lazy-one-to-one
branch
from
45e05b3 to
52831a9
Compare
DavideD
changed the title
|
We need to revisit a bit this area and update the docs. |
|
This pull request introduces 1 alert when merging 52831a9 into 78dab9a - view on LGTM.com new alerts:
|
When using Bytecode Enhancements with a lazy bidirectional one-to-one, we have an error because we rerturn a CompletionStage instead of using the fetched object. This commit should fix the issue.
Additional module for testing using Hibenrate ORM Bytecode Enhancements The module uses the Hibernate Gradle plugin to enable the features. This is not an elegant solution and there is some duplicated code from the core module, but it beats not being able to test these use cases.
DavideD
force-pushed
the
1417-lazy-one-to-one
branch
from
52831a9 to
cd3b4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1417
This should make it possible to fix the related issue on Quarkus.
I've decided to add an additional module to the project to test with bytecode enhancements. Hopefully, in the future we will have something better, but it beats not having tests. I've heard Hibernate ORM has some nice utilities for this.
Not sure how we didn't notice before, but the problem was that in this particular scenario we run a query that returns a CompletionStage and we try to assign it to one of the field. Instead we need to assign the result when it's ready.