Ignore hibernate.jdbc.use_get_generated_keys
#1552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, deleting 140 lines of code is nice :) |
|
I will change it to a draft because I'm still experimenting with some changes that should remove more unecessary code |
DavideD
force-pushed
the
identity-generator
branch
3 times, most recently
from
a42db94 to
b4f4c58
Compare
This property might make sense with JDBC. But the Vert.x client is less flexible about the type of queries it needs to read the id.
DavideD
force-pushed
the
identity-generator
branch
from
b4f4c58 to
94ed758
Compare
|
Now we don't need the dialect wrapper anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property might make sense with JDBC. But the Vert.x client is less flexible about the type of queries it needs to read the id.