properly parse query string during native select query #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
The fix looks correct, but we need to update the tests to make the build work |
|
Thank you for the quick responses. Is there anything I can do to help fix the tests? This issue is currently blocking my team from upgrading |
|
Never mind, it seems it was a problem with CI. |
Merged
|
Superseded by #1737 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
ReactiveNativeSelectQueryPlanImplwhere the sql query string was not getting processed by itsSQLQueryParser. Before adding this code, any select query which had{h-schema},{h-domain}, or{h-catalog}in the query string would throw an invalid sql grammar exception.