Remove release from GitHub #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
1956-release-update
branch
from
ace71b3 to
4a7c515
Compare
yrodiere
reviewed
Aug 28, 2024
| @@ -237,64 +237,3 @@ jobs: | |||
| with: | |||
| name: reports-java${{ matrix.java.name }} | |||
| path: './**/build/reports/' | |||
|
|
|||
| snapshot: | |||
There was a problem hiding this comment.
Do you plan to restore snapshot publishing somehow?
There was a problem hiding this comment.
Yes, I'm working on it now.
|
|
||
| env.RELEASE_VERSION = releaseVersion.toString() | ||
| env.DEVELOPMENT_VERSION = developmentVersion.toString() | ||
| // Dry run is not supported at the moment |
There was a problem hiding this comment.
You mean to add this in a later PR?
There was a problem hiding this comment.
Ah, this is just a leftover. Dry run is working
No problem. In the end I decided to merge it and apply changes later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1956
@yrodiere Maybe you want to have a quick look? It mimics the one pipeline in ORM, but I'm not updating the website and not using the JIRA. Basically, I've tried to keep the changes to the existing release task to a minimum.
I will improve everything when we have tested that it actually works with a real release.