Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default key comparer used by QuackingDictionary, and its child class Row, can't currently be changed.
My changes allow for a custom StringComparer to be specified upon instantiation. It is then preserved over row cloning and copying.
This can be useful in various scenarios:
My commit should be entirely backwards compatible and doesn't change existing behaviour. Nevertheless, for an easy performance improvement accross all users of the library, at very little cost, I would suggest changing the default value for QuackingDictionary.DefaultComparer to StringComparer.OrdinalIgnoreCase after my changes are pulled in. This should be nearly identical except in very remote corner cases, and tests on my computer have shown that it is up to 10x faster for hashing (which happens a lot in Rhino ETL applications).