Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom row key comparers #17

Merged
merged 1 commit into from
Dec 23, 2014

Conversation

david-durrleman
Copy link

The default key comparer used by QuackingDictionary, and its child class Row, can't currently be changed.

My changes allow for a custom StringComparer to be specified upon instantiation. It is then preserved over row cloning and copying.
This can be useful in various scenarios:

  • If case sensitivity is required for keys
  • If better performance is needed (my particular usecase)

My commit should be entirely backwards compatible and doesn't change existing behaviour. Nevertheless, for an easy performance improvement accross all users of the library, at very little cost, I would suggest changing the default value for QuackingDictionary.DefaultComparer to StringComparer.OrdinalIgnoreCase after my changes are pulled in. This should be nearly identical except in very remote corner cases, and tests on my computer have shown that it is up to 10x faster for hashing (which happens a lot in Rhino ETL applications).

@nathanpalmer
Copy link

Thanks for the pull @david-durrleman! This looks great and has a backward compatible API.

@nathanpalmer nathanpalmer merged commit 5e30f86 into hibernating-rhinos:master Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants