Bug Fix for issue: JoinOperation errors are not propagated to the main EtlProcess #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2015 18:01
…s with GetAllErrors method. Add AbstractJoinOperation class.
|
Another interesting point: in "Debug" VS configuration, no error is reported ! |
|
Thanks for the merge. When do you plan to release a new version of rhino-etl on NuGet? |
|
@koulkov It was just released as version 1.2.6 (1.3.0 is also out which includes the Common.Logging upgrade) |
|
Thanks a lot @nathanpalmer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes to fix this issue: #18
In addition, it creates a common AbstractJoinOperation shared by JoinOperation and NestedLoopsJoinOperation. So, similar code is not duplicated.
Thanks in advance for your feedback!