perf: Reuse rand for shuffling queues #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pior
reviewed
Oct 15, 2024
Instead of creating a new `rand.Rand` every time we need the next queues, we create it once and reuse it.
l0nax
force-pushed
the
perf-reuse-rand
branch
from
a07195d
to
f4d037f
Compare
kamikazechaser
added
help wanted
|
Don't forget to https://go.dev/blog/randv2 for best results. |
|
@kamikazechaser If it is okay with the project I can bump the Go version 1.23 and introduce a global rand generator. |
|
We guarantee to support the last 2 versions here: https://github.com/hibiken/asynq?tab=readme-ov-file#quickstart And since math/rand/v2 was introduced in 1.22...It should be ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new
rand.Randevery time we need the next queues, we create it once and reuse it.The reason for this change comes from monitoring our application: After a few minutes, the
github.com/hibiken/asynq.(*processor).queuesmethod will consume a tremendous amount of CPU time and create a lot of garbage.Since the
queuemethod is called in its own goroutine, there is no need to add any synchronization primitives.Here is the profiling flame graph of our application in a time window of 5 minutes:
