BPM Change support for V2.5 and V3.0 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChroMapper 0.9.646(昨年10/2以降のStable)で仕様変更(V2.5.0及びV3.0.0)になったBPM変更の処理に対応しました。
V2.5.0 及び V3.0.0 のBPM Eventsの仕様は以下の通りです
https://bsmg.wiki/mapping/map-format/beatmap.html#bpm-events
以下が従来(V1)形式とV2.5.0以降の比較資料になります。
追記:Python 3.12だとSyntax Errorにならなくて気が付かなかったのですが、3.11以前だとエラーになったので修正しました。
6/19追記:BPM変更が無い譜面(最後のBPM変更よりも後のブックマーク)でdurationの計算が異常値になっていたので修正しました。