Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change date fields to a format more obvious of dd-mon-year. for example to make 2023-dec-01 #129

Closed
a1ch3mist opened this issue Mar 22, 2024 · 2 comments
Labels
bug Something isn't working data Relates to user provided data urgent Needs to be addressed quickly

Comments

@a1ch3mist
Copy link

I was entering dates in as m/d/yr (e.g. 12/1/2023) and google took that to mean Jan 12, 2023. I didn't catch this until later.

To avoid date issues, change the format to spell the month dd-MON-yyyy something like that to prevent any issues

@hickeng hickeng added bug Something isn't working urgent Needs to be addressed quickly data Relates to user provided data labels Mar 25, 2024
@hickeng hickeng added this to the Extension filing for Tax Day milestone Mar 25, 2024
@hickeng
Copy link
Owner

hickeng commented Mar 25, 2024

Good suggestion - textual month and 4 digit year seems the only way to make this properly unambiguous.

It's just as problematic in the Excel version although that simply ends up converting some date values to pure text because month 13 doesn't exist... and your only indication is difference in text alignment.

hickeng added a commit that referenced this issue Mar 26, 2024
Issue #129 notes an issue with date entry and potential for confusion.

I've updated the sheet in-place to 0.1.7-b with a change to the date formatting, and added notes to the documentation about using ISO date formats.

I'll need to update the sheets in the repo before the issue can be closed however.
@hickeng
Copy link
Owner

hickeng commented Mar 27, 2024

I've updated the shared sheets with the format change (did so on Monday). Still need to apply the change to the sheets in the repo.

@hickeng hickeng moved this from Todo to In Progress in VMware/Broadcom merger finances Mar 27, 2024
hickeng pushed a commit that referenced this issue Apr 8, 2024
The date format was ISO, eg. 2001-01-31, but with that format for display
it's not apparent if the date has been entered incorrectly for RSUs where
the date tends to be on the first of the month.

As such this updates the format to 2021-Jan-31 so that it's utterly
unambiguous for read back.

Fixes #130
Fixes #129
@hickeng hickeng closed this as completed in 8538782 Apr 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in VMware/Broadcom merger finances Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data Relates to user provided data urgent Needs to be addressed quickly
Projects
Development

No branches or pull requests

2 participants