Refines the per lot requirement option #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This added logic to look at the future ordinary income impact to see if it made a difference, but it only impacts the lots that would see substantial impact are newer ones that are assigned cash. Added Custom Function to switch back to Balanced Added optimizer log output in CSV form Substantial refactor of optimizer code. Avoid serializing scripted injected values. Added validations to ensure user inputs are not negative values.
This experimented with a synthetic basis to consider the potential reduction in tax from holding for longer when calculating lot distribution. Adding in LTG didn't have noticable effect and STG & state are much more involved. Think I'm calling it here and this fixes #49 Additionally adds STG column for ESPP despite all 0's for consistency in calculation logic. Includes ordinary income in the 2023 estimate if selling
hickeng
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional Tweak to experiment with impact of sale date for AVGO on LTG/STG/ordinary income.
Adds preliminary hack for experimenting with different synthetic basis calcs. Really this just wants Microsoft Excel solver.
The added logic showed no effect as the lots it has impact from are the new ones that get assigned as cash.
Added Custom Function to switch back to Balanced and to select which basis to use for optimization.
Added optimizer log output in CSV form for reference as to which lots are assigned what cash/stock ratio.
Substantial refactor of optimizer code.
Avoid serializing values that scripts injected into the sheet.
Added validations to ensure user inputs are not negative values.