Remove broken mtls code to fix CI #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some older crates were broken on current nightly, so I threw a dependency update in here. |
bluejekyll
approved these changes
May 21, 2024
1 task
6 tasks
|
@bluejekyll any timeline to cut a new release per this PR merge? |
|
@chenrui333 what's the motivation here? This has been broken since forever, and only just recently started warning. If you're requiring everything to build without warnings in the homebrew setup, that seems like a problem. We could push out another alpha release but I don't think we're going to expedite the 0.25.0 release for this. See #2206 for more discussion of the 0.25.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly Rust started warning about undefined features, which broke CI:
https://github.com/hickory-dns/hickory-dns/actions/runs/9172380557/job/25219060007
The
mtlsfeature seems to have been added in a broken state in #117 and has never since been fixed. I wouldn't be surprised if the same use case can work today by providing a preconfigured rustlsClientConfigwith client authentication enabled. In either case, it seems unlikely that this code will ever be fixed, so probably better to remove it.