Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token swap and price chart #10976

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Token swap and price chart #10976

wants to merge 3 commits into from
+95 −2

Conversation

salman-neslit
Copy link
Collaborator

@salman-neslit salman-neslit commented Feb 13, 2025 •
edited
Loading

Link to Issue

Closes: #10623

Description of Changes

  • Added a Gecko Terminal price chart widget to the Contests Page to display live token pricing.
  • Integrated an embedded Uniswap widget that provides trading functionality directly on the Contests Page.

"How We Fixed It"

Test Plan

  • Use FF FLAG_NEW_CONTEST_PAGE
  • Use FF FLAG_UNISWAP_TRADE
  • Use FF FLAG_LAUNCHPAD
  • go to contest/contestAddress
  • Confirmed that the Gecko Terminal chart displays live data.
  • Verified that the Uniswap widget embeds correctly and responds to interactions.

Deployment Plan

Other Considerations

@salman-neslit salman-neslit marked this pull request as ready for review February 13, 2025 13:09
masvelio
masvelio reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please handle empty state for mobile token swap and price chart. Add some copy, at least something like "Token swap no available" or how to make it available.

image
image

  1. not sure why (probably uniswapp) is killing my browser. After 1 minute it is getting so slow and another minute it is not responsive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masvelio masvelio masvelio left review comments

@Israellund Israellund Awaiting requested review from Israellund

@mzparacha mzparacha Awaiting requested review from mzparacha

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token swap and price chart
2 participants
@salman-neslit @masvelio