Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voting rules and timezone to FC frame #10981

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

masvelio
Copy link
Contributor

Link to Issue

Closes: #10928
Closes: #10880

Description of Changes

The PR replaces the contest prizes frame with voting rules frame in the Farcaster integration. Key changes include:

  • Removed contestPrizes.tsx and added votingRules.tsx
  • Updated time display format to include timezone using timeZoneName: 'longGeneric'
  • Changed "Prizes" button to "Voting Rules" in the contest card
  • Updated router paths to reflect the new voting rules endpoint

Test Plan

  • create farcaster contest
  • load the frame and verify that
  • timezone is visible
  • there is no prizes button anymore. Instead, there is voting rules button

image

image

Deployment Plan

  1. n/a

Other Considerations

  • n/a

@masvelio masvelio changed the title Marcin/farcaster fixes Add voting rules and timezone to FC frame Feb 13, 2025
@masvelio masvelio marked this pull request as ready for review February 13, 2025 16:03
@masvelio masvelio merged commit 64ff9e6 into master Feb 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Voting Rules" tab to the frame Add a timezone to the contest end date in farcaster frame
3 participants