Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add comment feature #19

Merged
merged 17 commits into from
Aug 10, 2023
Merged

feat: add comment feature #19

merged 17 commits into from
Aug 10, 2023

Conversation

wenhwang97
Copy link
Contributor

@wenhwang97 wenhwang97 commented Aug 7, 2023 •
edited
Loading

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist

  • This PR can be reviewed in under 30 minutes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have assigned reviewers to this PR.

cbolles
cbolles requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@cbolles cbolles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. Have some gql best practice suggestions

packages/server/src/app.module.ts Show resolved Hide resolved
packages/server/src/comment/comment.model.ts Outdated Show resolved Hide resolved
packages/server/src/comment/comment.resolver.ts Outdated Show resolved Hide resolved
packages/server/src/comment/comment.dto.ts Outdated Show resolved Hide resolved
packages/server/src/comment/comment.resolver.ts Show resolved Hide resolved
packages/server/src/comment/comment.model.ts Outdated Show resolved Hide resolved
packages/server/src/file/file.resolver.ts Show resolved Hide resolved
packages/server/src/file/file.service.ts Outdated Show resolved Hide resolved
@wenhwang97 wenhwang97 requested a review from cbolles August 9, 2023 20:03
cbolles
cbolles requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@cbolles cbolles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more suggestions. Also I would recommending adding comments so its easier to now if the fileId at a given point means the generated UUID or the mongoDB generated _id. I like adding the description to the resolver since they show up as documentation in the GraphQL playground

packages/server/src/comment/comment.resolver.ts Outdated Show resolved Hide resolved
packages/server/src/comment/comment.resolver.ts Outdated Show resolved Hide resolved
packages/server/src/file/file.resolver.ts Outdated Show resolved Hide resolved
@wenhwang97 wenhwang97 requested a review from cbolles August 9, 2023 20:36
cbolles
cbolles approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@cbolles cbolles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I appreciate you sticking with me on all the GraphQL stuff

@wenhwang97 wenhwang97 merged commit ea53609 into main Aug 10, 2023
@wenhwang97 wenhwang97 deleted the wenhan/feat/file-comment branch August 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbolles cbolles cbolles approved these changes

@gregfrasco gregfrasco Awaiting requested review from gregfrasco

@am5815 am5815 Awaiting requested review from am5815

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenhwang97 @cbolles