Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DebugLogEnable.h #16

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Update DebugLogEnable.h #16

merged 3 commits into from
Oct 3, 2023

Conversation

ErezBinyamin
Copy link
Contributor

@ErezBinyamin ErezBinyamin commented Sep 27, 2023

Change macro name to not trample builtin str

Change macro name to not trample builting `str`
@ErezBinyamin
Copy link
Contributor Author

Discovered this bug when trying to debug an issue I was having with ArduinoJson

Copy link
Owner

@hideakitai hideakitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please check the comment.

DebugLogEnable.h Outdated Show resolved Hide resolved
Changed name of helper macros to be more descriptive of their functionality.
Copy link
Owner

@hideakitai hideakitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hideakitai hideakitai merged commit 991cd1a into hideakitai:main Oct 3, 2023
14 checks passed
@ErezBinyamin ErezBinyamin deleted the patch-1 branch October 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants