-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Use int64 in argmax #103
Comments
Thanks @soodoshll, should be fixed in #111. |
KTong821
added a commit
to KTong821/hidet
that referenced
this issue
Apr 24, 2024
Infrastructure for compiled stable diffusion app. Towards hidet-org#57
vadiklyutiy
pushed a commit
that referenced
this issue
Jul 22, 2024
Infrastructure for compiled stable diffusion app. Towards #57
vadiklyutiy
pushed a commit
that referenced
this issue
Jul 23, 2024
Infrastructure for compiled stable diffusion app. Towards #57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now hidet uses int32 as the return type of ArgReduceTask,
hidet/python/hidet/graph/ops/definitions/reduce/reduce.py
Line 102 in 33cfcbb
which is misaligned with torch and onnx that return int64, leading to incompatibility with other operators. Like concatenation requires inputs to have the same dtype. So concatenating the output of argmax with an int64 tensor is legal in torch but illegal in hidet.
Here is a simple snippet:
which raises an error:
The text was updated successfully, but these errors were encountered: