Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test Publish on wheel or not #462

Closed
vadiklyutiy opened this issue Jul 26, 2024 · 5 comments
Closed

[CI] Test Publish on wheel or not #462

vadiklyutiy opened this issue Jul 26, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request Task Or "Story" in JIRA's term.
Milestone

Comments

@vadiklyutiy
Copy link
Collaborator

I merged #461 to be able release the version. But there is unresolved discussion.

I think we should use the wheel package for final testing, not a clone of repo. If there are any issues in the wheel we didn't check it.

@wangshangsam @yaoyaoding

@vadiklyutiy vadiklyutiy added enhancement New feature or request Task Or "Story" in JIRA's term. labels Jul 26, 2024
@yaoyaoding
Copy link
Member

I merged #461 to be able release the version. But there is unresolved discussion.

I think we should use the wheel package for final testing, not a clone of repo. If there are any issues in the wheel we didn't check it.

@wangshangsam @yaoyaoding

I think so, it's better to

  1. build the release wheel with scripts/wheel/build_wheel_manylinux1.sh.
  2. run the test using the built wheel that we are going to release.

@wangshangsam
Copy link
Collaborator

I think we should use the wheel package for final testing, not a clone of repo.

+1

@vadiklyutiy
Copy link
Collaborator Author

We immediately got proof of this claim :)

@vadiklyutiy
Copy link
Collaborator Author

@wangshangsam wangshangsam added this to the 0.5.0 milestone Aug 15, 2024
vadiklyutiy pushed a commit that referenced this issue Dec 19, 2024
vadiklyutiy pushed a commit that referenced this issue Dec 20, 2024
@vadiklyutiy
Copy link
Collaborator Author

Right now Tests workflow use wheel for testing

vadiklyutiy pushed a commit that referenced this issue Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task Or "Story" in JIRA's term.
Projects
None yet
Development

No branches or pull requests

4 participants