Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamo] Added Operator Support #131

Merged
merged 14 commits into from
Mar 16, 2023
Merged

Conversation

AndreSlavescu
Copy link
Contributor

No description provided.

Copy link
Member

@yaoyaoding yaoyaoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a minor comment.

tests/frontends/torch/test_torch_hardsigmoid.py Outdated Show resolved Hide resolved
@AndreSlavescu AndreSlavescu changed the title [Dynamo] Sigmoid/Hardsigmoid Operators [Dynamo] Added Operator Support Mar 9, 2023
Copy link
Member

@yaoyaoding yaoyaoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A minor issue is to drop the change for ir/primitives/math.py

python/hidet/graph/frontend/torch/register_functions.py Outdated Show resolved Hide resolved
python/hidet/ir/primitives/math.py Show resolved Hide resolved
@yaoyaoding
Copy link
Member

Thanks @AndreSlavescu.

@yaoyaoding yaoyaoding merged commit 3cbaa81 into hidet-org:main Mar 16, 2023
KTong821 pushed a commit to KTong821/hidet that referenced this pull request Apr 24, 2024
The previous implementation is incorrect when dealing with a pair of
dimensions that are both symbolic. Minimal example:

import hidet

if __name__ == "__main__":
    x = hidet.symbol(["n"])
    y = hidet.symbol(["m"])
    z = x + y
    print(x.shape, y.shape, z.shape) # before: (n,) (m,) (m,)
vadiklyutiy pushed a commit that referenced this pull request Jul 22, 2024
The previous implementation is incorrect when dealing with a pair of
dimensions that are both symbolic. Minimal example:

import hidet

if __name__ == "__main__":
    x = hidet.symbol(["n"])
    y = hidet.symbol(["m"])
    z = x + y
    print(x.shape, y.shape, z.shape) # before: (n,) (m,) (m,)
vadiklyutiy pushed a commit that referenced this pull request Jul 23, 2024
The previous implementation is incorrect when dealing with a pair of
dimensions that are both symbolic. Minimal example:

import hidet

if __name__ == "__main__":
    x = hidet.symbol(["n"])
    y = hidet.symbol(["m"])
    z = x + y
    print(x.shape, y.shape, z.shape) # before: (n,) (m,) (m,)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants