[Operators] Conv2d gemm fp16 performance enhancement #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not tested
test for numerical differences
|
Additionally, I removed an extra cp_async statement in fp16_matmul |
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
In parallel runs of the regression tests, the compilation server might fail when checking/loading the config file. This change handles the specific case where those files are checked as non existent, but when they attempting to create it, they would return `FileExistsError`. examples: [1](https://github.com/CentML/playground/actions/runs/9601931045) [2](https://github.com/CentML/playground/actions/runs/9601633511) If you think this should be handled some other way, just let me know and i'll make the change.
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
In parallel runs of the regression tests, the compilation server might fail when checking/loading the config file. This change handles the specific case where those files are checked as non existent, but when they attempting to create it, they would return `FileExistsError`. examples: [1](https://github.com/CentML/playground/actions/runs/9601931045) [2](https://github.com/CentML/playground/actions/runs/9601633511) If you think this should be handled some other way, just let me know and i'll make the change.
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
In parallel runs of the regression tests, the compilation server might fail when checking/loading the config file. This change handles the specific case where those files are checked as non existent, but when they attempting to create it, they would return `FileExistsError`. examples: [1](https://github.com/CentML/playground/actions/runs/9601931045) [2](https://github.com/CentML/playground/actions/runs/9601633511) If you think this should be handled some other way, just let me know and i'll make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for pointwise convolution, use matmul.