[Operator] Further performance enhancements for conv2D #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Aalanli
commented
Jun 23, 2023
Aalanli
commented
- changed matmul_fp16 to support last dimension a multiple of 2 or 4
- added custom pre-transform kernel to replace auto scheduler generated version
- moved padding to within the conv2d operator to remove redundant padding
not tested
test for numerical differences
|
More changes: |
|
Hi @Aalanli, let me know (by ping me in the PR) if this PR is ready to be reviewed. Sometimes I am not sure whether a PR is ready to be reviewed even when the CI is passed. You can also add [WIP] prefix (work in progress) to the PR title explicitly if you are still working on a PR. |
|
Hi @yaoyaoding, thanks for the message. This PR is ready to be reviewed. |
yaoyaoding
reviewed
Jun 26, 2023
yaoyaoding
approved these changes
Jun 28, 2023
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
- setitem with tensor values - boolean type promotion --------- Co-authored-by: Zhumakhan <nazirzhumakhan@gmail,.com>
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
- setitem with tensor values - boolean type promotion --------- Co-authored-by: Zhumakhan <nazirzhumakhan@gmail,.com>
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
- setitem with tensor values - boolean type promotion --------- Co-authored-by: Zhumakhan <nazirzhumakhan@gmail,.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.