[BUG] Fix bug in cast in quantization
#480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadiklyutiy
added a commit
that referenced
this pull request
Dec 21, 2024
This reverts commit 04332b7.
vadiklyutiy
added a commit
that referenced
this pull request
Dec 21, 2024
vadiklyutiy
pushed a commit
that referenced
this pull request
Dec 26, 2024
### PR Description This PR addresses the issue outlined in [Issue #227](CentML/hidet#227). #### Problem: After investigation, the problem arises because multiple threads were writing to the same `fused_ir` directory. This led to race conditions where one thread might attempt to delete a file that another thread had already removed. Moreover, all candidates were being saved into a single directory, resulting in overwriting of files across different threads. #### Solution: This commit introduces the following changes to resolve the issue: 1. **Separate Directories for Each Candidate**: - Each candidate now gets its own directory under `fuse_ir`, preventing conflicts and file overwriting. 2. **Subdirectories for IRs by Candidate**: - The `ir` files are now stored in separate subdirectories under `candidate/ir`, ensuring that files from different candidates are isolated. 3. **Test Case Added**: - A new test case was introduced to verify that the number of folders in `fuse_ir` matches the total number of candidates listed in `candidate.txt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] Fix bug in
castin quantization