build: run tests on module path

[jjohannes]

Description:

Update hiero-gradle-conventions to 0.4.1 and by that run tests on the module path.

See hiero-ledger/hiero-consensus-node#18922 for more details on how that works.

Blocked until hcn 0.63.0 is released: Need to wait for next hcn (swirlds version) release as patched module name io.prometheus.simpleclient was changed to simpleclient which is the name expected by module-info.class files published in helidon modules.

[jjohannes]

@AlfredoG87 I figured that we temporarily can add patch code for com.swirlds.common to workaround the renaming issue until 0.63 is released. Then this does not block the other updates.

[jjohannes]

@AlfredoG87 @jasperpotts With moving tests to the Module Path, the test BlockNodeAppTest.testMain() behaves different. The service registry is now available at test time. Also, loading one of a duplicated resource in the root of the module/class path behaves different. It is an unstable thing to rely on in any case. There is a duplication with app/src/main/resources/app.properties and app/src/test/resources/app.properties. I propose two changes, but please let me know if we should solve this differently:

• Rename app/src/test/resources/app.properties to app/src/test/resources/app-test.properties and prefer the latter one if available. This is similar to what Spring boot supports for such a use case.
• Adjust main() method test code to no longer expect an Exception.

[jsync-swirlds]

We can also consider suppressing the test generation by PBJ so that we do not create or run those tests at all (it is an option in the PBJ compiler now).
Those tests verify that PBJ is correct, which isn't particularly necessary to run here.

[AlfredoG87]

@AlfredoG87 @jasperpotts With moving tests to the Module Path, the test BlockNodeAppTest.testMain() behaves different. The service registry is now available at test time. Also, loading one of a duplicated resource in the root of the module/class path behaves different. It is an unstable thing to rely on in any case. There is a duplication with app/src/main/resources/app.properties and app/src/test/resources/app.properties. I propose two changes, but please let me know if we should solve this differently:

• Rename app/src/test/resources/app.properties to app/src/test/resources/app-test.properties and prefer the latter one if available. This is similar to what Spring boot supports for such a use case.
• Adjust main() method test code to no longer expect an Exception.

I agree with the approach 👍

[AlfredoG87]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...in/java/org/hiero/block/node/app/BlockNodeApp.java	75.00%	0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@             Coverage Diff              @@
##               main    #1104      +/-   ##
============================================
+ Coverage     84.33%   84.41%   +0.07%     
- Complexity      915      941      +26     
============================================
  Files           105      107       +2     
  Lines          3786     3901     +115     
  Branches        415      424       +9     
============================================
+ Hits           3193     3293     +100     
- Misses          423      431       +8     
- Partials        170      177       +7     

Files with missing lines	Coverage Δ	Complexity Δ
...in/java/org/hiero/block/node/app/BlockNodeApp.java	88.18% <75.00%> (+5.12%)	13.00 <0.00> (+2.00)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AlfredoG87]

LG

[jsync-swirlds]

This is a bit concerning, as this module both requires and exports to the com.swirlds.config.extensions module.

As noted above, this module really should not be exporting anything, so we probably need to fix whatever is needing us to export here.

Outside the scope of this PR, but I've filed an issue to investigate and resolve.