Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CodeCov fix attempt #692

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: CodeCov fix attempt #692

wants to merge 3 commits into from

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Feb 22, 2025

Reviewer Notes

This is the second attempt to fix CodeCov, this time without downgrading (rolling back) the GHA action codecov/codecov-action

Taking example from mirror node where is working with this version.

Before:
image

After: 🤞
Try 2:
image

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87 AlfredoG87 self-assigned this Feb 22, 2025
@AlfredoG87 AlfredoG87 added this to the 0.5.0 milestone Feb 22, 2025
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87
Copy link
Contributor Author

AlfredoG87 commented Feb 22, 2025

@jjohannes Can you validate why with new hiero gradle plugins we need to set manually on each subproject to generate xml jacoco reports. seems like only html is set by default.

@andrewb1269hg this seems to fix it 👍 🥳

@AlfredoG87 AlfredoG87 marked this pull request as ready for review February 22, 2025 05:53
@AlfredoG87 AlfredoG87 requested review from a team as code owners February 22, 2025 05:53
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Copy link

codecov bot commented Feb 22, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant