fix: Also archive config.txt as part of network archiving process #18427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
mhess-swl
changed the title
hedera-node/hedera-app/src/main/java/com/hedera/node/app/info/DiskStartupNetworks.java
Show resolved
Hide resolved
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Neeharika-Sompalli
previously approved these changes
Mar 24, 2025
There was a problem hiding this comment.
LGTM! Thanks @mhess-swl. Please validate that the error no more exists with the test you were doing.
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where
forceUseOfConfigAddressBookis still enabled, theconfig.txtfile must be archived in order to avoid an ISS on node restarts. This PR fulfills this requirement via movingconfig.txtfrom the node's working directory to thedata/config/.archivedirectory with the other archived network files.Closes #18270