feat: remove duplication of web3 client verrsion method

[natanasow]

Description:

Currently, there are two implementations of the web3 client version method.

Solution:

Research why we've added both of them (is the first one deprecated) and remove the non-standard one.

Related issue(s):

Fixes #3505

Notes for reviewer:

After some research, we found out that there is no web3_client_version in any JSON RPC standard even in the deprecated ones.

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

Test Results

 18 files   -   4  236 suites   - 44   33m 8s ⏱️ - 26m 16s
617 tests + 18  613 ✅ + 30  4 💤 ±0  0 ❌  - 12 
633 runs   - 180  629 ✅  - 166  4 💤 ±0  0 ❌  - 14 

Results for commit 2f687e9. ± Comparison against base commit 00d411b.

This pull request removes 5 and adds 23 tests. Note that renamed tests count towards both.

"after all" hook in "RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests "after all" hook in "RPC Server Acceptance Tests"
"before all" hook in "HBAR Rate Limit Tests" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests "before all" hook in "HBAR Rate Limit Tests"
"before each" hook for "Should eventually exhaust the hbar limit for EXTENDED user and still allow another EXTENDED user to make calls" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers EXTENDED Tier "before each" hook for "Should eventually exhaust the hbar limit for EXTENDED user and still allow another EXTENDED user to make calls"
"before each" hook for "Should increase the amount spent of the spending plan by the transaction cost" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers PRIVILEGED Tier "before each" hook for "Should increase the amount spent of the spending plan by the transaction cost"
should execute "web3_client_version" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests @release Hardcoded RPC Endpoints should execute "web3_client_version"

should associate to a nft ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests should associate to a nft
should associate to a token with custom fees ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests should associate to a token with custom fees
should associate to a token ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests should associate to a token
should be able to approve anyone to spend tokens ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests HTS Precompile Approval Tests should be able to approve anyone to spend tokens
should be able to delete a token ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests HTS Precompile Delete Token Tests should be able to delete a token
should be able to execute getApproved on nft ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests HTS Precompile Approval Tests should be able to execute getApproved on nft
should be able to execute setApprovalForAllPublic ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests HTS Precompile Approval Tests should be able to execute setApprovalForAllPublic
should be able to get a custom token fees ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests HTS Precompile Custom Fees Tests should be able to get a custom token fees
should be able to get default KYC status for fungible token ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests HTS Precompile KYC Tests should be able to get default KYC status for fungible token
should be able to get default KYC status for non fungible token ‑ RPC Server Acceptance Tests Acceptance tests @tokencreate HTS Precompile Token Create Acceptance Tests HTS Precompile KYC Tests should be able to get default KYC status for non fungible token
…

♻️ This comment has been updated with latest results.

[quiet-node]

LGTM

[quiet-node]

Approved but however, we should also reach out to DAs to make sure this removal is not blocking anyone

[acuarica]

Out of curiosity, do we know why we added it in the first place?

[natanasow]

Out of curiosity, do we know why we added it in the first place?

TBH I don't know. I tried to dig deeper but it was added a long time ago (September 2022) and I didn't find any clue.

[Ferparishuertas]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[quiet-node]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (00d411b) to head (2f687e9).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
+ Coverage   85.38%   85.55%   +0.16%     
==========================================
  Files          74       74              
  Lines        4777     4777              
  Branches      985      985              
==========================================
+ Hits         4079     4087       +8     
+ Misses        407      403       -4     
+ Partials      291      287       -4     

Flag	Coverage Δ
config-service	95.16% <ø> (ø)
relay	79.38% <ø> (ø)
server	84.71% <ø> (+0.43%)	⬆️
ws-server	36.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/server/src/koaJsonRpc/lib/methodConfiguration.ts	100.00% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.